flatpak-builder icon indicating copy to clipboard operation
flatpak-builder copied to clipboard

[Bug]: flatpak-builder rejects AppData file that passes appstream-util

Open TobTobXX opened this issue 3 years ago • 3 comments

Checklist

  • [X] I agree to follow the Code of Conduct that this project adheres to.
  • [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.2.2

Flatpak version

1.14.0

How to reproduce

  1. Get (or clone) the manifest and appdata.xml from here: https://git.sr.ht/~tobtobxx/org.example.repro
  2. Validate the appdata.xml:
$ appstream-util validate-relax org.example.repro.appdata.xml
org.example.repro.appdata.xml: OK
  1. Try to build the application

Expected Behavior

It may succeed or fail due to another reason.

Actual Behavior

Processing application org.example.repro
Error loading AppData file: failed to parse /app/share/appdata/org.example.repro.appdata.xml: Error on line 15 char 56: <li> already set ',' and tried to replace with ' and '
Error: ERROR: appstream-compose failed: Child process exited with code 1

Additional Information

appstream-util --version: 0.8.1

This may as well be an issue with some appstream library, but flatpak docs tell me it needs to pass appstream-util validate-relax. And the issues seen in validate (strict) are not related to the <li> tags or whatever.

And this also happens when I replace the <b> with <em> tags.

TobTobXX avatar Oct 31 '22 19:10 TobTobXX

Huh, I just noticed that the bug does not occur when I use org.freedesktop.Platform as base. I'll raise the issue on the KDE platform repo.

TobTobXX avatar Oct 31 '22 19:10 TobTobXX

We use a modified version of the tool that you can install: flatpak install flathub org.freedesktop.appstream-glib

TingPing avatar Oct 31 '22 19:10 TingPing

Good to know, but makes no difference:

~/p/f/org.example.repro > flatpak run org.freedesktop.appstream-glib validate-relax org.example.repro.appdata.xml
org.example.repro.appdata.xml: OK

TobTobXX avatar Oct 31 '22 20:10 TobTobXX

f-b has switched to libappstream so this issue is no longer valid.

TingPing avatar Feb 24 '24 22:02 TingPing