flatpak-builder icon indicating copy to clipboard operation
flatpak-builder copied to clipboard

rename-appdata-file is not case sensitive in the application id within the appdata file

Open nedrichards opened this issue 4 years ago • 0 comments

Flatpak-builder version

flatpak-builder 1.0.10 (but also whatever is available on flathub)

Flatpak version

1.8.2 (with whatever Endless patches are in Endless OS 3.9.1)

Description of the problem

The minitube app on flathub has a different capitalisation for its app-id than upstream. (org.tordini.flavio.Minitube vs org.tordini.flavio.minitube). In order to create a compliant appdata which passes the flathub requirements you need to include this in your manifest:

"rename-appdata-file": "org.tordini.flavio.minitube.metainfo.xml",

However this just renames the file and leaves the lowercase app-id within the id element in the appdata, which then fails to compile as it does not exactly match the expected format. See this PR for an example: https://github.com/flathub/org.tordini.flavio.Minitube/pull/17

Renaming the appdata file needs to be case sensitive in the renames it does within the appdata file as well as renaming the file itself.

nedrichards avatar Jan 13 '21 11:01 nedrichards