flatpak-builder-tools
flatpak-builder-tools copied to clipboard
cargo: Handle excluded paths in workspaces
Should fix #322
@gasinvein is this still valid since the fixed bug has been closed?
Yes, the issue was closed by mistake I believe.
I believe that the main problem in #322 is that the script eagerly loads the manifest of every package in a git source and tries to resolve all of its dependencies, even if we don't need the package in the end.
When we encounter a package, we should always check if it's listed in the Cargo.lock
, otherwise we can safely skip it. So I see two options:
- Keep the list of packages in Cargo.lock around and check it every time, it would probably be the simplest as it only involves passing a list around
- Load the source first, and then resolve only the packages we need lazily, but that might probably involve deeper changes.
Edit: Actually, it seems like #399 would fix #322.
#399 was merged. And other fixes too. Maybe it's worth retrying.