flatpak-builder-tools icon indicating copy to clipboard operation
flatpak-builder-tools copied to clipboard

empty build commands for meson

Open christianrauch opened this issue 4 years ago • 6 comments

I am trying to generate the module build commands for meson via ./flatpak-pip-generator meson but the resulting commands in python3-meson.json are empty:

{
    "name": "python3-meson",
    "buildsystem": "simple",
    "build-commands": [],
    "modules": []
}

The log does not show warnings or errors:

========================================================================
Downloading sources
========================================================================
Running: "pip3 download --exists-action=i --dest /tmp/pip-generator-python3-mesons8em0uta -r /tmp/requirements.1mcyjcl7"
Collecting meson
  Using cached meson-0.61.0-py3-none-any.whl (849 kB)
Saved /tmp/pip-generator-python3-mesons8em0uta/meson-0.61.0-py3-none-any.whl
Successfully downloaded meson
========================================================================
Downloading arch independent packages
========================================================================
========================================================================
Obtaining hashes and urls
========================================================================
Generating hash for meson-0.61.0-py3-none-any.whl
Extracting download url for meson
========================================================================
Generating dependencies
========================================================================

Output saved to python3-meson.json

christianrauch avatar Jan 16 '22 03:01 christianrauch

This is probably because Meson is already present in the SDK. Why do you need to generate it?

gasinvein avatar Jan 16 '22 09:01 gasinvein

I wanted to install a newer version of meson.

christianrauch avatar Jan 16 '22 12:01 christianrauch

For now you can manually edit it out here: https://github.com/flatpak/flatpak-builder-tools/blob/master/pip/flatpak-pip-generator#L297

We should add a flag to override system versions though.

TingPing avatar Jan 17 '22 19:01 TingPing

That explains why this is ignored entirely. Why are those packages blacklisted? Isn't it reasonable to assume that, if a user chooses to install a pip package manually, it is because a newer version is required? Also, there are other runtimes where this does not apply. So I think it is better to remove that blacklist entirely and let the user decide which packages to add to the flatpak.

christianrauch avatar Jan 18 '22 23:01 christianrauch

Isn't it reasonable to assume that, if a user chooses to install a pip package manually, it is because a newer version is required?

Yes I think that is fine and should be changed.

The list prevents other packages pulling in setuptools for example which is already installed.

Also, there are other runtimes where this does not apply.

Nothing that is a supported version.

TingPing avatar Jan 19 '22 01:01 TingPing

Even after removing meson from the blacklist, it is not installed correctly and the system/sdk version still takes precedence:

ERROR: Meson version is 0.59.4 but project requires >=0.60.0

christianrauch avatar Feb 12 '22 00:02 christianrauch