CaImAn icon indicating copy to clipboard operation
CaImAn copied to clipboard

Fix cropping method and add ability to save compressed .avi files with the FFV1 codec

Open emelon8 opened this issue 1 year ago • 0 comments

Description

This pull request fixes the cropping method in the movie class, which gives a ValueError when run (e.g., "ValueError: could not broadcast input array from shape (1000,340,348) into shape (1000,390,388)"). The changes make it so the cropped movie is returned and not cropped inline.

A second edit also allows timeseries.save to save .avi files using the FFV1 codec, which a lossless codec, resulting in a much smaller file size.

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)

Has your PR been tested?

It had one error running python caimanmanager.py test: the parallel test. I'm not sure what the issue is, since my edits are minor and shouldn't affect the parallel processing. I've recently been getting parallel errors with my computer (prior to any edits of the code), though, so that's likely the issue.

The demotest ran successfully.

emelon8 avatar Aug 15 '22 23:08 emelon8