flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add io.github.benjamimgois.goverlay

Open benjamimgois opened this issue 2 weeks ago • 6 comments

Please confirm your submission meets all the criteria

  • [X] Please describe the application briefly. < Goverlay is an easy graphical interface to configure MangoHud, vkBasalt, and OptiScaler >
  • [X] Please attach a video showcasing the application on Linux using the Flatpak. < https://github.com/user-attachments/assets/22220858-afb8-4e58-8c5c-74bb4f858a99 >
  • [X] The Flatpak ID follows all the rules listed in the Application ID requirements.
  • [X] I have read and followed all the Submission requirements and the Submission guide and I agree to them.
  • [X] I am an author of the project.

benjamimgois avatar Dec 14 '25 01:12 benjamimgois

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the following items are done:

github-actions[bot] avatar Dec 14 '25 02:12 github-actions[bot]

Starting a test build of the submission. Please fix any issues reported in the build log. You can restart the build once the issue is fixed by commenting the phrase below.

bot, build

github-actions[bot] avatar Dec 14 '25 20:12 github-actions[bot]

🚧 Test build enqueued.

flathubbot avatar Dec 14 '25 20:12 flathubbot

🚧 Started test build.

flathubbot avatar Dec 14 '25 20:12 flathubbot

Test build failed.

Help
  • bot, build - Restart the test build

flathubbot avatar Dec 14 '25 20:12 flathubbot

thanks for the feedback @hfiguiere ! it's my first flathub submission so i still have things to learn. I'll try to work on it when i got home

benjamimgois avatar Dec 15 '25 14:12 benjamimgois

Hi @hfiguiere and @bbhtt,

I've addressed all the feedback from the review:

  • Using org.freedesktop.Sdk.Extension.freepascal as requested
  • Changed source type from 'dir' to 'git' with proper tag and commit
  • Removed add-extensions for MangoHud and vkBasalt (now bundled)
  • Using portal notification (org.freedesktop.portal.Notification)
  • Removed /sys filesystem permission
  • Moved cleanup section above modules
  • Added Qt6 Wayland for complete Wayland support
  • Included Breeze Icons for better visual consistency

The manifest has been tested locally and builds successfully.

benjamimgois avatar Dec 17 '25 02:12 benjamimgois

I've addressed all the feedback from the review:

No. Because you just improvised and changed thing you were never asked to change.

Let me guess, you asked a chatbot.

hfiguiere avatar Dec 17 '25 03:12 hfiguiere

@hfiguiere I've done some changes in the manifest https://github.com/Twig6943/goverlayFlatpak/blob/main/io.github.benjamimgois.goverlay.yml , I need to solve this error tho

Not building lazarus manually since it's supposed to be provided by the sdk-extension?

image

Twig6943 avatar Dec 17 '25 18:12 Twig6943

Pushed said changes + some more

Twig6943 avatar Dec 18 '25 22:12 Twig6943

@hfiguiere anything else I should do or are we done here?

Twig6943 avatar Dec 19 '25 14:12 Twig6943

anything else left to do?

Twig6943 avatar Dec 21 '25 10:12 Twig6943

bot, build

bbhtt avatar Dec 21 '25 13:12 bbhtt

🚧 Test build enqueued.

flathubbot avatar Dec 21 '25 13:12 flathubbot

🚧 Started test build.

flathubbot avatar Dec 21 '25 13:12 flathubbot

Test build failed.

Help
  • bot, build - Restart the test build

flathubbot avatar Dec 21 '25 14:12 flathubbot

Test build failed.

Help

Looking into that metainfo parsing error right now.

Twig6943 avatar Dec 21 '25 14:12 Twig6943

Seems to be a syntax error made by me,

image

Testing a fix right now https://github.com/Twig6943/goverlayFlatpak/actions/runs/20411582494/job/58649192561

Twig6943 avatar Dec 21 '25 15:12 Twig6943

bot, build

Twig6943 avatar Dec 21 '25 15:12 Twig6943

🚧 Test build enqueued.

flathubbot avatar Dec 21 '25 15:12 flathubbot

🚧 Started test build.

flathubbot avatar Dec 21 '25 15:12 flathubbot

It went through https://github.com/flathub-infra/vorarbeiter/actions/runs/20412049800

Twig6943 avatar Dec 21 '25 16:12 Twig6943

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/238574/io.github.benjamimgois.goverlay.flatpakref

Built for aarch64 and x86_64 architectures.

flathubbot avatar Dec 21 '25 16:12 flathubbot

@bbhtt

Twig6943 avatar Dec 21 '25 16:12 Twig6943