flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add org.openstenoproject.Plover

Open vixalien opened this issue 4 months ago • 58 comments

Please confirm your submission meets all the criteria

  • [x] Please describe the application briefly. Free and open source stenography engine
  • [x] Please attach a video showcasing the application on Linux using the Flatpak.

https://github.com/user-attachments/assets/cb264baf-513a-485e-bf39-8aad01feac00

  • [x] The Flatpak ID follows all the rules listed in the Application ID requirements.
  • [x] I have read and followed all the Submission requirements and the Submission guide and I agree to them.
  • [x] I am an (please keep whichever is applicable and remove the rest) author/developer/upstream contributor to the project. If not, I contacted upstream developers about this submission. https://discordapp.com/channels/136953735426473984/136953735426473984/1405865035858837706 (via discord)

vixalien avatar Aug 17 '25 12:08 vixalien

bot, build

vixalien avatar Aug 17 '25 12:08 vixalien

🚧 Test build enqueued.

flathubbot avatar Aug 17 '25 12:08 flathubbot

🚧 Started test build.

flathubbot avatar Aug 17 '25 12:08 flathubbot

Test build failed.

flathubbot avatar Aug 17 '25 12:08 flathubbot

The app works (and uses Wayland) if I give it access to both wayland and x11.

For some weird reason, keeping the wayland and fallback-x11 fails with:

Unexpected error: Traceback (most recent call last):
  File "/app/lib/python3.12/site-packages/plover/scripts/main.py", line 147, in main
    code = gui.main(config, controller)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/plover/gui_qt/main.py", line 125, in main
    app = Application(config, controller, use_qt_notifications)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/plover/gui_qt/main.py", line 31, in __init__
    from plover.gui_qt.main_window import MainWindow
  File "/app/lib/python3.12/site-packages/plover/gui_qt/main_window.py", line 14, in <module>
    from plover.oslayer import wmctrl
  File "/app/lib/python3.12/site-packages/plover/oslayer/linux/wmctrl.py", line 4, in <module>
    _wmctrl = WmCtrl()
              ^^^^^^^^
  File "/app/lib/python3.12/site-packages/plover/oslayer/linux/wmctrl_x11.py", line 8, in __init__
    self._display = display.Display()
                    ^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/Xlib/display.py", line 89, in __init__
    self.display = _BaseDisplay(display)
                   ^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/Xlib/display.py", line 71, in __init__
    protocol_display.Display.__init__(self, *args, **keys)
  File "/app/lib/python3.12/site-packages/Xlib/protocol/display.py", line 84, in __init__
    name, protocol, host, displayno, screenno = connect.get_display(display)
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/Xlib/support/connect.py", line 73, in get_display
    return mod.get_display(display)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.12/site-packages/Xlib/support/unix_connect.py", line 59, in get_display
    raise error.DisplayNameError(display)
Xlib.error.DisplayNameError: Bad display name ""

I have resorted to just giving it access to just x11, and it works, but with following warnings:

flatpak run org.openstenoproject.Plover
2025-08-17 15:20:43,327 [MainThread] WARNING: Qt: Failed to create wl_display (No such file or directory)
2025-08-17 15:20:43,388 [MainThread] WARNING: Qt: Qt: Session management error: Could not open network socket
2025-08-17 15:20:43,494 [MainThread] WARNING: It appears that an input method, such as ibus or fcitx5, is not running on your system. Without this, some text may not be output correctly.

vixalien avatar Aug 17 '25 13:08 vixalien

bot, build

vixalien avatar Aug 17 '25 13:08 vixalien

🚧 Test build enqueued.

flathubbot avatar Aug 17 '25 13:08 flathubbot

🚧 Started test build.

flathubbot avatar Aug 17 '25 13:08 flathubbot

Test build failed.

flathubbot avatar Aug 17 '25 13:08 flathubbot

not sure why the build is failing...

vixalien avatar Aug 17 '25 13:08 vixalien

If it tries to connect to X11 regardless then the app doesn't support wayland correctly.

hfiguiere avatar Aug 17 '25 13:08 hfiguiere

There is no point retrying until the issue is fixed. It will not magically be hand waved.

hfiguiere avatar Aug 17 '25 13:08 hfiguiere

I understand that, I will see if I can fix the x11/wayland issue.

What's weird is that the build/CI is failing. I can't figure out why

vixalien avatar Aug 17 '25 13:08 vixalien

bot, build

vixalien avatar Aug 17 '25 13:08 vixalien

🚧 Test build enqueued.

flathubbot avatar Aug 17 '25 13:08 flathubbot

🚧 Started test build.

flathubbot avatar Aug 17 '25 13:08 flathubbot

I have reported the X11/Wayland issue upstream: https://github.com/openstenoproject/plover/issues/1763. For now, plover flatpak will use X11.

vixalien avatar Aug 17 '25 13:08 vixalien

The build seems successful, but it seems we don't get a test build link anymore...?

vixalien avatar Aug 17 '25 14:08 vixalien

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/204710/org.openstenoproject.Plover.flatpakref

flathubbot avatar Aug 17 '25 14:08 flathubbot

spoke too soon...

vixalien avatar Aug 17 '25 14:08 vixalien

works when I install the test flatpak

vixalien avatar Aug 17 '25 14:08 vixalien

The domain to be used for verification is openstenoproject.org. If you intend to verify this app, please confirm that you can upload https://openstenoproject.org/.well-known/org.flathub.VerifiedApps.txt. Otherwise, ignore this. Please comment if this incorrect.

github-actions[bot] avatar Aug 17 '25 15:08 github-actions[bot]

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the pull request title is Add $FLATPAK_ID and that all checklist items in the pull request body are marked as complete.

github-actions[bot] avatar Aug 17 '25 15:08 github-actions[bot]

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the pull request title is Add $FLATPAK_ID and that all checklist items in the pull request body are marked as complete.

Not sure how to fix this

vixalien avatar Aug 17 '25 22:08 vixalien

bot, build

vixalien avatar Aug 17 '25 22:08 vixalien

🚧 Test build enqueued.

flathubbot avatar Aug 17 '25 22:08 flathubbot

🚧 Started test build.

flathubbot avatar Aug 17 '25 22:08 flathubbot

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the pull request title is Add $FLATPAK_ID and that all checklist items in the pull request body are marked as complete.

Not sure how to fix this

image

hfiguiere avatar Aug 17 '25 22:08 hfiguiere

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/204782/org.openstenoproject.Plover.flatpakref

flathubbot avatar Aug 17 '25 22:08 flathubbot

okay, thanks! fixed

vixalien avatar Aug 18 '25 00:08 vixalien