flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add org.devsk.flatconvert

Open quentinSoranzoKrebs opened this issue 7 months ago • 29 comments

Please confirm your submission meets all the criteria

  • [x] Please describe the application briefly.
    FlatConvert is a simple and user-friendly multimedia conversion tool for GNOME. It allows users to convert video and image files to various formats using FFmpeg and Python Pillow under the hood. It integrates well with GNOME by following modern design patterns with GTK4 and libadwaita.

  • [x] The domain used for the application ID is controlled by the application developer(s) and the application id guidelines are followed.
    Application ID: org.devsk.flatconvert — The domain devsk.org (and the qsk namespace on GNOME GitLab) is controlled by the developer.

  • [X] I have read and followed all the Submission requirements and the Submission guide and I agree to them.

  • [x] I am an author/developer of the project.

Additional maintainers: None

quentinSoranzoKrebs avatar May 24 '25 13:05 quentinSoranzoKrebs

  • The domain devsk.org

There is nothing responding at this end.

hfiguiere avatar May 24 '25 14:05 hfiguiere

  • The domain devsk.org

There is nothing responding at this end.

quentinSoranzoKrebs avatar May 24 '25 17:05 quentinSoranzoKrebs

Build must be offline.

This was never addressed. Fix ALL the issue before asking for review.

hfiguiere avatar May 24 '25 22:05 hfiguiere

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the pull request title is Add $FLATPAK_ID and that all checklist items in the pull request body are marked as complete.

github-actions[bot] avatar May 25 '25 07:05 github-actions[bot]

I have addressed all the points raised: the offline build has been successfully verified, the devsk.org domain is now active, and the files have been thoroughly cleaned. I would appreciate it if you could kindly review the pull request again at your earliest convenience.

Thank you very much for your time and consideration.

quentinSoranzoKrebs avatar May 31 '25 16:05 quentinSoranzoKrebs

Hello, I have implemented the requested changes, including adding add-ld-path, specifying the creation of the required directory both in the Flatpak manifest and ensuring it exists in the sandboxed environment of the app, and updating the extension version to 24.08 (see commit 805bd8f). Could you please have another look when you have time? Thank you very much!

quentinSoranzoKrebs avatar Jun 01 '25 09:06 quentinSoranzoKrebs

Starting a test build of the submission. Please fix any issues reported in the build log. You can restart the build once the issue is fixed by commenting the phrase below.

bot, build

github-actions[bot] avatar Jun 16 '25 16:06 github-actions[bot]

🚧 Test build enqueued.

flathubbot avatar Jun 16 '25 16:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 16 '25 16:06 flathubbot

Test build failed.

flathubbot avatar Jun 16 '25 16:06 flathubbot

bot, build

quentinSoranzoKrebs avatar Jun 16 '25 17:06 quentinSoranzoKrebs

🚧 Test build enqueued.

flathubbot avatar Jun 16 '25 17:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 16 '25 17:06 flathubbot

Test build failed.

flathubbot avatar Jun 16 '25 17:06 flathubbot

🚧 Test build enqueued.

flathubbot avatar Jun 16 '25 20:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 16 '25 20:06 flathubbot

Test build failed.

flathubbot avatar Jun 16 '25 20:06 flathubbot

🚧 Test build enqueued.

flathubbot avatar Jun 17 '25 16:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 17 '25 16:06 flathubbot

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/192590/org.devsk.flatconvert.flatpakref

flathubbot avatar Jun 17 '25 16:06 flathubbot

bot, build

bbhtt avatar Jun 24 '25 14:06 bbhtt

🚧 Test build enqueued.

flathubbot avatar Jun 24 '25 14:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 24 '25 14:06 flathubbot

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/193783/org.devsk.flatconvert.flatpakref

flathubbot avatar Jun 24 '25 14:06 flathubbot

why do these start with _?

image

missing icon

image

missing icon + why "test page"? preferences are empty

image

what is "Aide" here? it opens the same dialogue as above

image

after conversion where does the file get saved? I see 20:05:24,091 - INFO - convert_thread.py - utilisation de _convert_img pour /run/user/1000/doc/d749b1fd/file_example_JPG_2500kB_converted.png in the terminal but i can't find it.

bbhtt avatar Jun 24 '25 14:06 bbhtt

bot, build

bbhtt avatar Jun 25 '25 11:06 bbhtt

🚧 Test build enqueued.

flathubbot avatar Jun 25 '25 11:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 25 '25 11:06 flathubbot

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/193936/org.devsk.flatconvert.flatpakref

flathubbot avatar Jun 25 '25 11:06 flathubbot