flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add io.github.Mrmayman.QuantumLauncher

Open Mrmayman opened this issue 7 months ago • 34 comments

Please confirm your submission meets all the criteria

  • [x] Please describe the application briefly:

QuantumLauncher is a lightweight, fast and powerful Minecraft launcher which supports features like a built in (free) content store, fully independent Minecraft installations, and fixes/patches for old Minecraft versions.

  • [x] Please include a screenrecord (10-20s) showcasing the application.

Quantumlauncher showcase.webm

Note

  • metainfo, icon, .desktop file are included in repo and are installed through build-commands. Please let me know if this is the wrong approach
  • the latest commit name was a mistake, i meant "add captions to screenshots" but typed something else

Mrmayman avatar May 24 '25 10:05 Mrmayman

bot, build

bbhtt avatar May 24 '25 13:05 bbhtt

🚧 Test build enqueued.

flathubbot avatar May 24 '25 13:05 flathubbot

🚧 Started test build.

flathubbot avatar May 24 '25 13:05 flathubbot

🚧 Test build failed.

flathubbot avatar May 24 '25 13:05 flathubbot

This pull request is temporarily marked as blocked as some automated checks failed on it. Please make sure the pull request title is Add $FLATPAK_ID and that all checklist items in the pull request body are marked as complete.

github-actions[bot] avatar May 25 '25 07:05 github-actions[bot]

the mentioned things have been fixed, and i have responded to the various questions. Anything left?

Mrmayman avatar May 25 '25 10:05 Mrmayman

bot, build

bbhtt avatar May 26 '25 00:05 bbhtt

🚧 Test build enqueued.

flathubbot avatar May 26 '25 00:05 flathubbot

🚧 Started test build.

flathubbot avatar May 26 '25 00:05 flathubbot

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/187779/io.github.Mrmayman.QuantumLauncher.flatpakref

flathubbot avatar May 26 '25 00:05 flathubbot

flatpak run io.github.Mrmayman.QuantumLauncher
            __                                                        
         __/##\__               ╔══╗ ╓  ╖ ╔══╗ ╔══╗ ═╦═ ╓  ╖ ╔═╦═╗
      __/###  ###\__            ║  ║ ║  ║ ╠══╢ ║  ║  ║  ║  ║ ║ ║ ║
   __/###        ###\__         ╚═╦╝ ╚══╝ ╙  ╜ ╙  ╜  ╜  ╚══╝ ╙   ╜
  /###    . . .     ###\        ╓    ╔══╗ ╓  ╖ ╔══╗ ╔══ ╓  ╖ ╔══ ╔══╗
  \#     .  .  .   ####/        ║    ╠══╢ ║  ║ ║  ║ ║   ╠══╢ ╠══ ╠═╦╝
   \#     . . #####___/         ╚═══ ╙  ╜ ╚══╝ ╙  ╜ ╚══ ╙  ╜ ╚══ ╙ ╜
    \#       #____/@@@@\____                                          
     \#     #/@@@@@@@@$$$$$$\   A simple, powerful Minecraft launcher
      \######|@@ @@@@@$$.$.$|   This window just shows debug info so  
       \_____|     @ ..$....|   feel free to ignore it                
             |       .......|                                         
             \____   .. ____/   For a list of commands type           
                  \____/        ./quantum_launcher --help

[info] Starting up the launcher...

thread 'main' panicked at /run/build/quantum-launcher/cargo/vendor/iced_winit-0.13.0/src/program.rs:192:10:
Create event loop: Os(OsError { line: 89, file: "/run/build/quantum-launcher/cargo/vendor/winit-0.30.10/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bbhtt avatar May 26 '25 01:05 bbhtt

flatpak run io.github.Mrmayman.QuantumLauncher
            __                                                        
         __/##\__               ╔══╗ ╓  ╖ ╔══╗ ╔══╗ ═╦═ ╓  ╖ ╔═╦═╗
      __/###  ###\__            ║  ║ ║  ║ ╠══╢ ║  ║  ║  ║  ║ ║ ║ ║
   __/###        ###\__         ╚═╦╝ ╚══╝ ╙  ╜ ╙  ╜  ╜  ╚══╝ ╙   ╜
  /###    . . .     ###\        ╓    ╔══╗ ╓  ╖ ╔══╗ ╔══ ╓  ╖ ╔══ ╔══╗
  \#     .  .  .   ####/        ║    ╠══╢ ║  ║ ║  ║ ║   ╠══╢ ╠══ ╠═╦╝
   \#     . . #####___/         ╚═══ ╙  ╜ ╚══╝ ╙  ╜ ╚══ ╙  ╜ ╚══ ╙ ╜
    \#       #____/@@@@\____                                          
     \#     #/@@@@@@@@$$$$$$\   A simple, powerful Minecraft launcher
      \######|@@ @@@@@$$.$.$|   This window just shows debug info so  
       \_____|     @ ..$....|   feel free to ignore it                
             |       .......|                                         
             \____   .. ____/   For a list of commands type           
                  \____/        ./quantum_launcher --help

[info] Starting up the launcher...

thread 'main' panicked at /run/build/quantum-launcher/cargo/vendor/iced_winit-0.13.0/src/program.rs:192:10:
Create event loop: Os(OsError { line: 89, file: "/run/build/quantum-launcher/cargo/vendor/winit-0.30.10/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

this is fedora 41 running on gnome boxes screenshot1

after perform a update, it works: sudo dnf4 update --refresh -y screenshot2 as you can see, this is not an upstream issue

apicalshark avatar May 26 '25 06:05 apicalshark

well it doesn't here and system packages has nothing to do with flatpak, so dnf foobar isn't going to work

bbhtt avatar May 26 '25 07:05 bbhtt

That's true but Fedora 41 iso does not work out of the box, it's outdated so it needs an system upgrade. If you dislike dnf, update button in gnome store works for me as well edit:

system packages has nothing to do with flatpak

thats not true, bottles flatpak breaks many time for me because fedora pushes breaking change upstream

apicalshark avatar May 26 '25 07:05 apicalshark

It has nothing to do with dnf.

bbhtt avatar May 26 '25 08:05 bbhtt

What it looks like (look at the error message) is that it absolutely want Wayland and doesn't find it. If running dnf influence it that way, then you app is totally broken.

hfiguiere avatar May 26 '25 11:05 hfiguiere

I think I have fixed the crash. I was able to reproduce the same issue, after this fix it doesn't happen for me. Can you take a look now?

I fixed it by unsetting WAYLAND_DISPLAY. It's not a great fix, but I think it should work.

I think this specific issue has been fixed, let me know if the fix isn't ideal/doesn't work, or if there's something else to be fixed

Mrmayman avatar May 28 '25 04:05 Mrmayman

in the latest commits i've changed the arg to --unset-env=WAYLAND_DISPLAY as requested

i've also bundled metainfo and desktop files into this repo instead of leaving them in the app repo, because these have a few fixes/modifications not present in the v0.4.1 release commit's files

Mrmayman avatar May 29 '25 06:05 Mrmayman

Then remove the desktop and metainfo files from here

bbhtt avatar May 29 '25 12:05 bbhtt

Then remove the desktop and metainfo files from here

Just to clarify, in the v0.4.1 tag commit (9d763e4b5358eb13e1f137fe8ed2beb546021c45), the .desktop and metainfo xml files in the app repository are missing a few last minute fixes:

  • The <launchable> tag is broken.
  • The screenshots are missing captions.

I fixed these issues only right after the release tag was created, but they're not present in the tagged commit that Flatpak builds from

Because of this, I included the corrected .desktop and metainfo.xml files directly in this PR instead of the app repository. This ensures that up to date metadata is present without requiring a new app release just for metadata

That said, I noticed other Flatpak PRs (e.g. #6505) have also included files in the PR instead of repo

Should I still remove the metainfo and desktop files from this PR and using the outdated versions in the repo, or is including them here acceptable in this case?

Mrmayman avatar May 30 '25 12:05 Mrmayman

Yes use the upstream ones in your repo and remove it from here. You can create a new tag or use a commit directly in the manifest

bbhtt avatar May 30 '25 13:05 bbhtt

okay, i created a new tag which contains the updated desktop and metainfo in the app repo. I've removed the files from PR now

Mrmayman avatar Jun 01 '25 06:06 Mrmayman

bot, build

bbhtt avatar Jun 01 '25 12:06 bbhtt

🚧 Test build enqueued.

flathubbot avatar Jun 01 '25 12:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 01 '25 12:06 flathubbot

🚧 Test build failed.

flathubbot avatar Jun 01 '25 12:06 flathubbot

bot, build

bbhtt avatar Jun 02 '25 01:06 bbhtt

🚧 Test build enqueued.

flathubbot avatar Jun 02 '25 01:06 flathubbot

🚧 Started test build.

flathubbot avatar Jun 02 '25 01:06 flathubbot

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/189175/io.github.Mrmayman.QuantumLauncher.flatpakref

flathubbot avatar Jun 02 '25 01:06 flathubbot