flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add org.kde.WaylandDecoration.QWhiteSurGtkDecorations

Open FengZhongShaoNian opened this issue 1 year ago • 14 comments

Please confirm your submission meets all the criteria

  • [x] Please describe the application briefly. Qt decoration plugin implementing WhiteSur-gtk-theme-like client-side decorations

  • [x] The domain used for the application ID is controlled by the application developers and the application id guidelines are followed.

  • [x] I have read the and followed all the Submission and licence requirements.

  • [x] I have built and tested the submission locally.

  • [x] I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about this submission. Link:

FengZhongShaoNian avatar Aug 04 '24 07:08 FengZhongShaoNian

Do you have any screenshots to see how it works?

bbhtt avatar Aug 04 '24 13:08 bbhtt

cc @flathub/kde

it this extension point even a thing?

hfiguiere avatar Aug 04 '24 13:08 hfiguiere

I heavily dislike how this is called org.kde.* given it's not software coming from kde.org

tsdgeos avatar Aug 04 '24 22:08 tsdgeos

isn't there an extension point for these in the KDE runtime (I didn't look)? For extensions there is no choice of id.

hfiguiere avatar Aug 04 '24 22:08 hfiguiere

Answering my question

[Extension org.kde.WaylandDecoration]
directory=share/runtime/lib/plugins/
no-autodownload=true
subdirectories=true
add-ld-path=lib
download-if=on-xdg-desktop-GNOME;on-xdg-desktop-GNOME-classic
merge-dirs=wayland-decoration-client
version=5.15-23.08

So yes.

hfiguiere avatar Aug 04 '24 23:08 hfiguiere

I heavily dislike how this is called org.kde.* given it's not software coming from kde.org

That's how extension points work in Flatpak. It's named by the where it is defined in, in this case the KDE runtime. These two aren't official KDE software either https://github.com/flathub/org.kde.WaylandDecoration.QGnomePlatform-decoration https://github.com/flathub/org.kde.WaylandDecoration.QAdwaitaDecorations

There won't be any way to verify extensions and verification info is hidden on the website for extensions.

bbhtt avatar Aug 05 '24 01:08 bbhtt

Do you have any screenshots to see how it works?

screenshot

It looks like this.

FengZhongShaoNian avatar Aug 05 '24 03:08 FengZhongShaoNian

For extensions there is no choice of id.

That's how extension points work in Flatpak

This seems like something flatpak should fix then :D

There won't be any way to verify extensions and verification info is hidden on the website for extensions.

So how does one figure out if an extension is from a trusted source or from a w4NaB3Hack3r?

tsdgeos avatar Aug 05 '24 21:08 tsdgeos

This seems like something flatpak should fix then :D

I just remembered that the org.gtk.Gtk3theme extension point does not match the ID prefix of the parent runtime. It's defined in freedesktop SDK and the gnome runtime none of which is org.gtk.

I guess you can define an extension point org.kdethirdpary.Plugin extension point in the KDE runtime for third party to consume.

You have to use a domain KDE owns in some way, otherwise random people can use it to verify.

The current org.kde.WaylandDecoration extension point can be removed when Qt 6.8 runtime is out, because as far as I know the plugin was upstreamed to Qt. Or even if it's not we can restrict submission to official KDE extensions only.

So how does one figure out if an extension is from a trusted source or from a w4NaB3Hack3r?

There isn't a good way, we hide it because it's un-verifiable and showing the yellow badge creates an expectation that it has to be verified.

bbhtt avatar Aug 06 '24 02:08 bbhtt

There isn't a good way

That is a sad thing.

tsdgeos avatar Aug 06 '24 21:08 tsdgeos

The question is will KDE runtime provide such an extension point for third party developers or shall we go on with this one?

bbhtt avatar Aug 07 '24 12:08 bbhtt

I've no idea, I'm not the person to decide that and I guess that should be discussed over at https://invent.kde.org/packaging/flatpak-kde-runtime or at the matrix channel and not here to have a proper group discussion.

tsdgeos avatar Aug 07 '24 20:08 tsdgeos

This is the commit that introduced them.

https://invent.kde.org/packaging/flatpak-kde-runtime/-/commit/2ac4fd348b9429fe687fa60a15f7f165dd262639

hfiguiere avatar Aug 08 '24 03:08 hfiguiere

I've no idea, I'm not the person to decide that and I guess that should be discussed over at https://invent.kde.org/packaging/flatpak-kde-runtime or at the matrix channel and not here to have a proper group discussion.

https://invent.kde.org/packaging/flatpak-kde-runtime/-/issues/60

bbhtt avatar Aug 08 '24 03:08 bbhtt

Can you retarget 6.8 runtime and use the org.inqlude.WaylandDecoration? This was specifically introduced for third party developers and the org.kde.WaylandDecoration. was removed.

bbhtt avatar Oct 31 '24 13:10 bbhtt

This hasn't received any updates in 6 months and will be automatically closed in 7 days. Please comment or reopen if necessary.

github-actions[bot] avatar May 04 '25 05:05 github-actions[bot]