flathub Move org.getmonero.Monero into the upstream repository

Move the manifest of org.getmonero.Monero into the monero-gui repository just like it's done in OBS .

Feb 12 '23 04:02 BigmenPixel0

So will anyone help?

Feb 26 '23 17:02 BigmenPixel0

Is there anything to actually review right now?

Feb 26 '23 21:02 barthalion

@barthalion we would like the monero flatpak to be pulled from the official repo.

Any pointers to documentation or how to get started would be greatly appreciated.

Also, Would this also add Verified Status? Is Flathub beta requires for both Verified and to self host?

Thanks, and apologies for not RTFM

Feb 27 '23 19:02 nahuhh

Please have a look at https://github.com/obsproject/obs-studio/blob/master/.github/workflows/flatpak.yml which uses https://github.com/flatpak/flatpak-github-actions to build its Flatpak. You can comment out flat-manager-client part and build only flatpak bundles for now – when we review the pipeline, I will send you a token allowing to push directly to our flatpak repository.

As for verification badge, @BigmenPixel0 can log in at https://beta.flathub.org/login and generate an HTTP token that needs to be exposed at a specific org.getmonero address.

Mar 14 '23 13:03 barthalion

Please have a look at https://github.com/obsproject/obs-studio/blob/master/.github/workflows/flatpak.yml which uses https://github.com/flatpak/flatpak-github-actions to build its Flatpak. You can comment out flat-manager-client part and build only flatpak bundles for now – when we review the pipeline, I will send you a token allowing to push directly to our flatpak repository.

As for verification badge, @BigmenPixel0 can log in at https://beta.flathub.org/login and generate an HTTP token that needs to be exposed at a specific org.getmonero address.

I have some questions about a token.

Could you send a token to the monero-gui repository owner (not now, I will message again)?
Is it possible to somehow protect the token from leaks (and not only. so this is not built on trust)? For example, so that you can push the application only from the certain source? (make a pull request, and then, a verify workflow on flathub repo could check, for example, that the hash of the build file is listed here https://www.getmonero.org/downloads/hashes.txt)

Apr 04 '23 15:04 BigmenPixel0

No. Once handed out the token, you are fully responsible for managing it securely.

Apr 04 '23 15:04 barthalion

@barthalion regarding question 1 above: can we get the token sent directly to a member of the Monero Core team (basically the trusted guardians of the project who maintain critical infrastructure) encrypted with one of their PGP keys? so only you and they know.

Apr 09 '23 00:04 plowsof

@barthalion can you encrypt the token with this public key https://raw.githubusercontent.com/monero-project/monero/master/utils/gpg_keys/luigi1111.asc and post the message here and i will get it to luigi. Thanks!

Apr 28 '23 17:04 plowsof

Well, I added appstream tool for validate the appdata every release. Is flatpak-builder-lint really needed? Because it's not in the fedora repositories (or is it in another package?).

May 13 '23 05:05 BigmenPixel0

@barthalion sir?

May 19 '23 12:05 plowsof

Please note this is a beta token. Let me know when a first build is uploaded so I can review it.

Jun 14 '23 11:06 barthalion

Also, Monero should get verified on flathub.org before I send you the stable token.

Jun 14 '23 11:06 barthalion

Please note this is a beta token

So does it upload the app to Flathub Beta?

Jun 16 '23 04:06 BigmenPixel0

Yes.

Jun 16 '23 08:06 barthalion

@barthalion A beta build was uploaded. https://github.com/monero-project/monero-gui/actions/runs/5895208662

Aug 18 '23 09:08 BigmenPixel0

Can you give a stable token?

Aug 26 '23 04:08 BigmenPixel0

Barth is on vacation and will probably return during the next week.

Aug 26 '23 14:08 razzeee

So..?

Sep 22 '23 03:09 BigmenPixel0

Any updates on this @barthalion? We need to obtain the verified status first right?

here is the workflow using the beta api key https://github.com/monero-project/monero-gui/blob/master/.github/workflows/flatpak.yml

Oct 15 '23 20:10 plowsof

I see two remotes being pushed out to flathub-beta right now, app/org.getmonero.Monero/x86_64/master (last commit 2023-10-11) and app/org.getmonero.Monero/x86_64/beta (last commit 2023-10-12). Which is the one I should be looking at?

Oct 17 '23 08:10 barthalion

If master is the one to look at, screenshots are not mirrored:

    <screenshots>
      <screenshot type="default">
        <caption>A screenshot of the Monero GUI wallet</caption>
        <image type="source">https://raw.githubusercontent.com/monero-project/monero-site/master/img/downloads/gui.png</image>
      </screenshot>
    </screenshots>

Oct 17 '23 08:10 barthalion

If master is the one to look at, screenshots are not mirrored:

    <screenshots>
      <screenshot type="default">
        <caption>A screenshot of the Monero GUI wallet</caption>
        <image type="source">https://raw.githubusercontent.com/monero-project/monero-site/master/img/downloads/gui.png</image>
      </screenshot>
    </screenshots>

Yes, master. Should it be solved so?

Oct 17 '23 09:10 BigmenPixel0

Yes, that's the right parameter. There are other upcoming changes:

Flathub will be enabling server-side build validation on a tentative date of November 6th. This will require some changes to your pipeline for publishing new builds:

the validation part can be replicated by using docker pull ghcr.io/flathub/flatpak-builder-lint:latest on the ostree repo produced by flatpak/flatpak-builder. Example usage: flatpak-builder-lint --exceptions repo /path/to/ostree/repo

flat-manager-client create needs to include --build-log-url $URL, where $URL points to a pipeline building the flatpak. This is also exposed by the latest release of the flatpak/flatpak-github-actions/flat-manager GitHub Action.

Also please make sure the pipeline that will be used to push stable build to regular Flathub uses stable branch.

Oct 17 '23 10:10 barthalion

Yes, that's the right parameter. There are other upcoming changes:

Flathub will be enabling server-side build validation on a tentative date of November 6th. This will require some changes to your pipeline for publishing new builds:

the validation part can be replicated by using docker pull ghcr.io/flathub/flatpak-builder-lint:latest on the ostree repo produced by flatpak/flatpak-builder. Example usage: flatpak-builder-lint --exceptions repo /path/to/ostree/repo

flat-manager-client create needs to include --build-log-url $URL, where $URL points to a pipeline building the flatpak. This is also exposed by the latest release of the flatpak/flatpak-github-actions/flat-manager GitHub Action.

Also please make sure the pipeline that will be used to push stable build to regular Flathub uses stable branch.

I don't understand well how does the linter work. What argument type do I have to enter? If repo, which path? Also, does it have to start before the building or after? And at the end, how should I perform the second point in github-actions? :)

Oct 19 '23 13:10 BigmenPixel0

@barthalion, could you review this?

Oct 21 '23 11:10 BigmenPixel0

@barthalion, are you waiting for the verified status? We want to get it after (after this moving). Do we have to do it before?

Nov 05 '23 09:11 BigmenPixel0

The new automatic workflow (without barth involved) needs to first have verification, before you can push anything afaik

Nov 05 '23 12:11 razzeee

ping!

May 23 '24 12:05 Nurmagoz

Is @barthalion even still active?

Consider opening an issue at https://github.com/flathub/flathub to ask about this so maybe someone else from Flathub can reply and not waiting forever for a person that is no longer responsive?

Jul 08 '24 12:07 adrelanos

Yes, I am. Maybe try to look around before producing another notification cluttering my inbox?

Unless the app gets verified and https://github.com/monero-project/monero-gui/pull/4231 is merged, I don't think there's much to talk about right now.

Jul 08 '24 15:07 barthalion

flathub flathub copied to clipboard

Move org.getmonero.Monero into the upstream repository

flathub
flathub copied to clipboard