flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Add Dragon Player

Open Mailaender opened this issue 3 years ago • 9 comments

Please confirm your submission meets all the criteria

  • [X] I have read the App Requirements and App Maintenance pages.
  • [X] My pull request follows the instructions at App Submission.
  • [X] I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • [X] All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • [X] I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://matrix.to/#/#flatpak:kde.org
  • [ ] I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • [X] Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) https://invent.kde.org/multimedia/dragon/-/merge_requests/3

Mailaender avatar Jun 01 '22 12:06 Mailaender

Note: the file selection does not open, drag and drop however works → beta channel candidate.

Mailaender avatar Jun 01 '22 12:06 Mailaender

bot, build org.kde.dragonplayer

Mailaender avatar Jun 01 '22 12:06 Mailaender

Queued test build for org.kde.dragonplayer.

flathubbot avatar Jun 01 '22 12:06 flathubbot

cc @flathub/kde

hfiguiere avatar Jun 01 '22 12:06 hfiguiere

Started test build 94196

flathubbot avatar Jun 01 '22 13:06 flathubbot

Build 94196 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/91925/org.kde.dragonplayer.flatpakref

flathubbot avatar Jun 01 '22 13:06 flathubbot

The open file dialog doesn't show up ^_^

tsdgeos avatar Jun 01 '22 14:06 tsdgeos

Yeah, I think not being able to open files the obvious way is a blocker for now.

nedrichards avatar Jun 04 '22 19:06 nedrichards

I noticed that opening a file via Dolphin already works, so I submitted it.

Mailaender avatar Jun 05 '22 08:06 Mailaender

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

flathubbot avatar Jun 06 '23 01:06 flathubbot

I suggest to put it in beta.

Mailaender avatar Jun 06 '23 08:06 Mailaender

maybe¿ what others think @travier ?

tsdgeos avatar Jun 06 '23 19:06 tsdgeos

Dragon has changed quite a bit since this PR was opened; can you rebase with 23.04.1 and try again, maybe? It's possible the issue with opening files from the app as gone away already.

Pointedstick avatar Jun 06 '23 19:06 Pointedstick

bot, build org.kde.dragonplayer

Mailaender avatar Jun 07 '23 09:06 Mailaender

Queued test build for org.kde.dragonplayer.

flathubbot avatar Jun 07 '23 09:06 flathubbot

Started test build 45652

flathubbot avatar Jun 07 '23 09:06 flathubbot

Seems it is indeed already fixed.

Mailaender avatar Jun 07 '23 09:06 Mailaender

Build 45652 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28272/org.kde.dragonplayer.flatpakref

flathubbot avatar Jun 07 '23 09:06 flathubbot

Indeed, fixed for me too.

Pointedstick avatar Jun 07 '23 17:06 Pointedstick

+1 from me

Pointedstick avatar Jun 07 '23 17:06 Pointedstick

I have

kf.solid.backends.udisks2: Failed enumerating UDisks2 objects: "org.freedesktop.DBus.Error.Disconnected" 
 "Not connected to D-Bus server"
kf.solid.backends.udisks2: Failed enumerating UDisks2 objects: "org.freedesktop.DBus.Error.Disconnected" 
 "Not connected to D-Bus server"

and unrelated to above, I wasn't able to play video files :/

travier avatar Jun 07 '23 18:06 travier

Worked fine on KDE Neon using X11.

Mailaender avatar Jun 07 '23 18:06 Mailaender

bot, build org.kde.dragonplayer

Mailaender avatar Jun 07 '23 18:06 Mailaender

Queued test build for org.kde.dragonplayer.

flathubbot avatar Jun 07 '23 18:06 flathubbot

Started test build 45771

flathubbot avatar Jun 07 '23 18:06 flathubbot

Build 45771 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28391/org.kde.dragonplayer.flatpakref

flathubbot avatar Jun 07 '23 18:06 flathubbot

Looks reasonably good to me

tsdgeos avatar Jun 07 '23 21:06 tsdgeos

OK, it does play some video files. Let's do it.

travier avatar Jun 08 '23 08:06 travier

CC @barthalion @nedrichards

travier avatar Jun 08 '23 08:06 travier

Ping @barthalion @nedrichards Please reopen.

Mailaender avatar Jun 23 '23 09:06 Mailaender