flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

RFE: Add the module name in the Github PR for updates

Open Justinzobel opened this issue 2 years ago • 2 comments

I'd really love to see the module name in FEDC PRs. Saves a click. Example https://github.com/flathub/org.kde.krdc/pull/48 just says Update 2.11.2.tar.gz to 3.0.0 which isn't overly informative.

If it's just one module, it would be in the title of the MR. If it's multiply it could just be done like so:

SomeModule: Update from 2.11.2 to 3.0.0
SomeOtherModule: Update from 2.11.2 to 3.0.0

Justinzobel avatar Dec 15 '23 04:12 Justinzobel

This is because you are using plain tags, the filename of the tag does not have the name of the source.

The update message includes the filename

https://github.com/flathub/flatpak-external-data-checker/blob/b9b5770e480624e9d7adbab1176d89d94cd1d573/src/manifest.py#L454-L456

If you switch it to https://github.com/FreeRDP/FreeRDP/releases/download/2.11.4/freerdp-2.11.4.tar.gz, it'll include the name in the title.

If it's multiply it could just be done like so

This would make the title unnecessarily verbose when there are many modules needing updates, the details are included in the commit message and PR description.

bbhtt avatar Dec 15 '23 04:12 bbhtt

It's true that in other cases the tarball name gives a better message but I do agree that there is scope for improving the commit message(s) and/or PR message. Patches welcome!

I actually think the case where 2+ sources change is more of a problem because the message becomes "Update 2 modules". Maybe you can find a way to improve that, e.g. if all changed sources belong to the same module, name the module; or highlight the main source; etc.

wjt avatar Dec 15 '23 07:12 wjt