flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

Always create description tag

Open razzeee opened this issue 2 years ago • 4 comments

I think it makes sense to create these empty tags always. Even if it means there will be a few more bytes to download.

I hope this will motivate some more maintainers to actually fill out the description.

Also it will be handy for me, cause I always need to look up the exact syntax whenever I get an update, as I usually forget it.

razzeee avatar Jun 10 '23 22:06 razzeee

I'm also not sure how to get that one test to have the correct padding

razzeee avatar Jun 10 '23 22:06 razzeee

I briefly looked at the padding today. It's confusing and I can't quite remember why I felt it to be so important to preserve formatting in badly-formatted files. I think it was because if this automation was to be forced on 500+ apps, I wanted it to be as well-behaved as possible so people didn't hate its PRs.

Maybe the logic could be made less fancy and/or that test dropped. But it should be possible to get it to work. I'll try to get back into the mind of myself circa 2019 on a flight home from Greece..

wjt avatar Nov 08 '23 20:11 wjt

OK, the logic was rewritten since that flight home from Greece, but I kind of got my head around it and figured out something that works. Unfortunately I also discovered that the existing logic is broken in some edge cases, but I marked that new test case as xfail and moved on!

wjt avatar Nov 09 '23 15:11 wjt

So how to proceed?

razzeee avatar Dec 01 '23 15:12 razzeee