flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

automatic upgrade to libchamplain

Open albfan opened this issue 2 years ago • 3 comments

https://github.com/flathub/nl.sarine.gpx-viewer/pull/5

How this is supposed to work, detect an outdated dependency and trigger an update with a PR, show the build problems on CI and expect maintainers to fix it?

albfan avatar Jan 19 '23 08:01 albfan

That's right.

wjt avatar Jan 19 '23 09:01 wjt

But is just a suggestion or something that will brake or discontinue the app if not addressed?

albfan avatar Jan 19 '23 13:01 albfan

The bot opened the PR because of this block in the manifest:

https://github.com/flathub/nl.sarine.gpx-viewer/blob/master/nl.sarine.gpx-viewer.json#L43-L46

It detected that a newer version of that library is available, and generated the PR. You can just close the PR and it won't reopen it. The app will continue to work.

Looking at the NEWS for libchamplain: the main change seems to be to add libsoup3 support. In some future version of the GNOME runtime, libsoup2 will presumably be removed, and so you'll need to update libchamplain at the same time as switching to such a future runtime version.

wjt avatar Jan 19 '23 14:01 wjt