flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

[Feature] Show link to changelogs in update PRs

Open dreua opened this issue 2 years ago • 2 comments

It would be nice to have a link to each package's changelog in the PRs. For some dependencies I'd like to review them before merging. At least for Pypi I assume a changelog link should be easy enough to get via the API, other platforms could be added on demand.

What do you think about that idea?

dreua avatar Jan 04 '23 00:01 dreua

Any thoughts? Would you merge if I implemented it myself?

dreua avatar Oct 03 '23 12:10 dreua

Sounds great to me!

wjt avatar Oct 30 '23 13:10 wjt

I've added two PRs which already work for me locally. Feedback welcome!

First I thought that the changelog link would need to be a template (to insert the current version) but in my limited test so far I ended up with static urls only, so the name changelog-url-template is currently not adequate. Either there should be actual templating support or the name needs to be changed. Shorter might be better anyway, but I'd love to get some feedback before I start changing it.

Example manifest, the submodule already contains autogenerated test data by the pip generator.

dreua avatar Feb 18 '25 02:02 dreua

I think I'll just rename the keys to changelog-url without template. Templating support can still be added later if needed, but for now I don't see the need. Any other feedback or ideas? (@wjt, @stsdc)

dreua avatar Apr 08 '25 10:04 dreua