flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

Check for updates to shared-modules submodule

Open nanonyme opened this issue 4 years ago • 5 comments

This is only loosely part of manifest IOW it's tracked externally, then included into manfiest. It would be great to have it automatically updated as well though to make sure everyone gets to benefit of improvements done to shared-modules.

nanonyme avatar Jun 12 '21 13:06 nanonyme

This is to some extent similar to #161

gasinvein avatar Jun 12 '21 14:06 gasinvein

I can't find where this was discussed before. IMO it is fine to just chase the tip of shared-modules and other submodules, but I think the change should only be proposed if it updates a file in the submodule which the manifest actually uses. Otherwise every commit to shared-modules will trigger hundreds of useless PRs

wjt avatar Jun 12 '21 19:06 wjt

Found it! https://github.com/flathub/flathub/pull/1372

wjt avatar Jun 12 '21 19:06 wjt

the change should only be proposed if it updates a file in the submodule which the manifest actually uses

That's good idea. But it would require noticeably more complex logic. Moreover, not all git submodules contain flatpak-builder modules, e.g. in the Telegram flatpak we have a git submodule with a set of patches.

gasinvein avatar Jun 12 '21 19:06 gasinvein

In the meantime everyone who wants can use dependabot to check for submodule updates.

dreua avatar Oct 06 '23 00:10 dreua