flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

Update only when two sources are at the same version number

Open TheEvilSkeleton opened this issue 4 years ago • 1 comments

I'm not sure exactly how to explain this, but the com.github.Eloston.UngoogledChromium flatpak Chromium and ungoogled-chromium patches require to be at the same version. See:

  • https://github.com/flathub/com.github.Eloston.UngoogledChromium/blob/master/com.github.Eloston.UngoogledChromium.yaml#L176
  • https://github.com/flathub/com.github.Eloston.UngoogledChromium/blob/master/com.github.Eloston.UngoogledChromium.yaml#L253

Since Chromium (the latter) comes with updates sooner than ungoogled-chromium's patches, flathubbot starts building the ungoogled-chromium flatpak without the new patches. See https://github.com/flathub/com.github.Eloston.UngoogledChromium/pull/18.

How can I make flathubbot only PR when both versions are the same?

TheEvilSkeleton avatar Mar 02 '21 22:03 TheEvilSkeleton

How can I make flathubbot only PR when both versions are the same?

You can't, sources are independent from each other. Although it makes sense to implement interconnection between modules. I'm not yet sure how to approach this, so ideas welcome.

gasinvein avatar Mar 02 '21 23:03 gasinvein