scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Fix GHA CI for PRs from external contributors

Open jepio opened this issue 1 year ago • 0 comments

Fix GHA CI for PRs from external contributors

GHA CI fails for PRs from external contributors because in devcontainer tests, emerge-gitclone can't fetch the right ref from the upstream repository. We can make this work by:

  1. switching to encoding a full sha in the FLATCAR_VERSION string in GHA
  2. using that full sha with git fetch origin <sha>; git checkout FETCH_HEAD in emerge-gitclone

This PRs does "1." and switches to using a branch of flatcar-dev-util that does "2." (https://github.com/flatcar/flatcar-dev-util/compare/jepio/fetch-head - PR will follow if this works).

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • [ ] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • [ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

jepio avatar Nov 28 '24 12:11 jepio