scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Drop eclass tests, move obsolete eclasses to overlay

Open krnowak opened this issue 1 year ago • 6 comments

We weren't syncing the eclass tests for ages and we weren't running them, so their existence in portage-stable is pointless at the moment. Also, three eclasses were removed from Gentoo, so we move them to our overlay as there is still a package or two that are using them.

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1682/cldsv/

krnowak avatar Aug 20 '24 15:08 krnowak

CI passed (I didn't run any tests - no package has changed, so I was only checking if stuff still builds.)

krnowak avatar Aug 21 '24 09:08 krnowak

epatch is only used in one place and you simply need to replace the command with eapply.

chewi avatar Aug 21 '24 09:08 chewi

epatch is only used in one place and you simply need to replace the command with eapply.

Okay, I see it is inherited by eutils. You could just remove that entry though.

chewi avatar Aug 21 '24 09:08 chewi

To be honest, I'd rather just drop the few remaining instances of EAPI 6. Gentoo has literally just purged almost all of them this week. It won't take me long at all.

chewi avatar Aug 21 '24 09:08 chewi

To be honest, I'd rather just drop the few remaining instances of EAPI 6. Gentoo has literally just purged almost all of them this week. It won't take me long at all.

That's obviously I'd like to eventually do. I think that the only Gentoo-derivative user of these eclasses in our overlay is sys-boot/syslinux. I think I tried updating the package or moving it to portage-stable long time ago, but there was something with newer version that broke our stuff, so I put that on hold and eventually forgot. Sorry for being vague, but yeah, it was long time ago (over 2 years ago, I think). There are other packages with EAPI 6 in overlay (git grep EAPI=.*6 will show them), but they should be trivial to handle.

For now I wanted to just move the obsolete eclasses, so that nothing breaks and the github automation will stop complaining about them being missing in Gentoo.

krnowak avatar Aug 21 '24 11:08 krnowak

As discussed elsewhere, I have dropped all instances of EAPI 6, so we can just remove these eclasses now. I will open a new PR to succeed this one.

chewi avatar Aug 22 '24 17:08 chewi