nebraska icon indicating copy to clipboard operation
nebraska copied to clipboard

Allow using multiple teams

Open krnowak opened this issue 5 years ago • 2 comments

Applicable after #16 is merged.

Currently when we log in, we pick up a single coreroller team (based on the github organization and team) and manage the applications maintained by that team only. Would be nice if after logging in, we could use all the coreroller teams that match all the github organizations and teams the user is member of.

krnowak avatar Oct 10 '18 22:10 krnowak

Currently when we log in, we pick up a single coreroller team (based on the github organization and team) ...

Does this break with multiple teams? (re https://github.com/kinvolk/coreroller/pull/16#issuecomment-429826148)

schu avatar Oct 15 '18 12:10 schu

Results might not be reproducible if the user is a member of multiple github teams that have their counterparts on the coreroller side. Basically rollerd will pick up the first suitable team from the list returned by the github API. So if github API returns teams in different order everytime, the user will be able to manage different sets of application in every session…

So we can either implement multiple teams in coreroller (which would mean changing some SQL queries from WHERE team_id == $1 to something like WHERE team_id IN (…).

Or, as you proposed in #16, drop coreroller teams and specify members of which github org and team can manage application through the command line or some env var.

krnowak avatar Oct 15 '18 12:10 krnowak