mantle icon indicating copy to clipboard operation
mantle copied to clipboard

api/equinixmetal: allows using different port for webserver storage

Open tormath1 opened this issue 1 year ago • 1 comments

One can now provide a URL like: ssh+http://1.2.3.4:8088 to upload the temporary artifacts on server 1.2.3.4 via SSH and download the artifacts from http://1.2.3.4:8088

tormath1 avatar Aug 29 '24 13:08 tormath1

Just noticed that this is for a review for 3 months already. Heh.

Um, looks ok I think. What is this for?

Yeah, it is not an emergency to get this merged so I did not insist on this review. For Equinix Metal, we boot an instance using PXE: PXE configuration and Ignition configuration can be stored on a Google Cloud Storage bucket or a regular HTTP server. This PR allows to configure SSH port and HTTP port. Before that, it was impossible to use an HTTP port different from 80.

tormath1 avatar Nov 14 '24 12:11 tormath1

Although there's a short future left for Equinix Metal, this LGTM. Not sure if it's worth merging or just cleaning up at this point though.

tylerauerbeck avatar Jun 28 '25 05:06 tylerauerbeck

yes, let's close this. If someone (likely me) still needs it until then, it is still possible to apply the PR patch.

tormath1 avatar Jul 02 '25 14:07 tormath1