Flatcar icon indicating copy to clipboard operation
Flatcar copied to clipboard

[RFE] Repos: enforce PR reviews (2-person rule) for scripts and ebuild repos

Open t-lo opened this issue 3 years ago • 2 comments

Current situation

2-person rule is obeyed for most changes but not enforced.

Impact

In theory the same person filing a PR could merge it.

Ideal future situation

Github feature for enforcing 2-person rule is active on repos in the Flatcar org. At least scripts, coreos-overlay, and portage-stable should be covered. An exception needs to be made for version file updates and tags generated by build automation in scripts.

t-lo avatar Jul 27 '22 10:07 t-lo

Looks like a duplicate of https://github.com/flatcar/Flatcar/issues/1714 now.

dongsupark avatar Jun 27 '25 09:06 dongsupark

Looks like a duplicate of #1714 now.

I think at this point the original issue has become very very long, so its a good idea to start creating sub-issues to address individual problems. So I will connect this one as a sub-issue

John15321 avatar Jun 27 '25 14:06 John15321