Flask-GoogleMaps icon indicating copy to clipboard operation
Flask-GoogleMaps copied to clipboard

Add drawing support for polylines, polygons, rectangles, home button

Open chriscowley opened this issue 8 years ago • 4 comments

This is a feature I for one would love to use

chriscowley avatar Mar 28 '16 19:03 chriscowley

all the code needed is in #17 but we dont want to merge it, only use as reference and implement in proper way using the new style added in 0.2.0

I have plans to work on this, but I prefer if someone can help sending small Pull Requests to implements all of that.

rochacbruno avatar Jun 29 '16 01:06 rochacbruno

the #17 has the beggining, but more info is here: https://developers.google.com/maps/documentation/javascript/tutorial

rochacbruno avatar Jun 29 '16 02:06 rochacbruno

Hi @rochacbruno,

I'm willing to work on this issue but I'm trying to understand what you meant by "new style added in 0.2.0". I was reading the code of issue #17 and my understanding is that you want a refactor of the PR code. I tested locally and it's working, so as far as I can see, it's more of a code style and some adaptations (for instance the gmap.varname references in gmapjs.html file)

Could you elaborate more explicitly on what should be done in this issue?

chicao avatar Jul 07 '16 13:07 chicao

@chicao we only need to get the changes added in Python module and adapt all the JS code, because that code breaks gmap dynamic name in gmapsjs.html so it is not possible to have more than one map in the same page.

Exactly what you said, code style adaptations in gmapsjs.html and keeping all the examples.py working. (did not find a way to test the map, so examples.py is our test here.)

rochacbruno avatar Jul 07 '16 14:07 rochacbruno