flashultra

Results 59 comments of flashultra

Thank you for reviewing this pull request. About the comments: * Well, this is possible, but different implementation can expose different methods, so some methods can exist only in Java,...

I think this pull request can be reviewed and merged as I added the missing methods ( abs, pow, modPow, isProbablePrime, getLowestSetBit and bitLength) and all the tests for them....

Php tests fails on another test. I think the bigint tests should pass the Php target.

All tests are green except PHP ( and mac-cpp which failed with other reason) . For php test I tried to run on my server , but I've got the...

The above error is when I test with PHP 8.1. I ran a new test with PHP 7.3 and all tests passed. This PR is ready to be merged.

Two things can be improved in the future : 1) Better GCD algorithm (using [Lehmer's GCD](https://en.wikipedia.org/wiki/Lehmer%27s_GCD_algorithm)) 2) Faster detection of prime numbers ( for isProbablePrime() and nextProbablePrime() methods) 3) Faster...

As I'm not a main contributor in this repository I can't comment if this is possible or not. For all new files I put the standard license available in the...

Thank you @Aurel300 for your comment. If @cbatson wants, I can add in each file something like ```/*Thanks to Charles H. Batson III , the original author of this implementation...

C is not my strong side, but maybe something like this in uv.c ? ( for string result IP : PORT ) ```C static char * get_peername(uv_tcp_t *t) { char...

I tried to return struct ```C #define _ADDR _OBJ(_BYTES _I32) DEFINE_PRIM(_ADDR, get_peername, _TCP ); typedef struct { char *ip; int *port; } addr_data ; HL_PRIM addr_data HL_NAME(get_peername)(uv_tcp_t *t) { char...