go-guerrilla icon indicating copy to clipboard operation
go-guerrilla copied to clipboard

panic: send on closed channel

Open orestonce opened this issue 4 years ago • 0 comments

  • startWG.Done does not ensure that s.Start() returns to completion, nor does it ensure that the writing of errs <- err is completed. Calling close(errs) directly after startWg.Wait() may close a channel being written to, resulting in panic。

https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L484

  • panic may position: https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L476 https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L484

orestonce avatar Sep 14 '20 23:09 orestonce