go-guerrilla icon indicating copy to clipboard operation
go-guerrilla copied to clipboard

200 OK response on NOOP command

Open mibes opened this issue 5 years ago • 1 comments

At the moment go-guerrilla returns a 200 OK upon receiving a NOOP command. Our client expects a 250 OK. The latter seems to be in line with the RFC.

We fixed this by making the following code change in enhanced.go:

        Canned.SuccessNoopCmd = &Response{
		EnhancedCode: OtherOrUndefinedProtocolStatus,
		BasicCode:    250,
		Class:        ClassSuccess,
	}

If this does not break anything else, you may consider this change for an upcoming release.

mibes avatar Mar 15 '19 13:03 mibes

Thanks, will update it soon.

flashmob avatar Apr 03 '19 05:04 flashmob