go-guerrilla icon indicating copy to clipboard operation
go-guerrilla copied to clipboard
verified publisher icon flashmob

Improve tests

Open flashmob opened this issue 7 years ago • 3 comments

Keeping this open as a general issue for improving existing unit tests. PRs welcome.

Also relevant, feedback in issue #96

flashmob avatar Jun 06 '18 00:06 flashmob

Also, sometimes the tests fail on Travis, but all green when the build is restarted - TODO: investigare why and find a solution.

flashmob avatar Jun 06 '18 00:06 flashmob

https://travis-ci.org/flashmob/go-guerrilla/jobs/389595164 --- FAIL: TestServerStopEvent (1.98s) serve_test.go:637: Could not connect to new server 127.0.0.1:2228

flashmob avatar Jun 08 '18 14:06 flashmob

Merged #131 which included a lot of fixes to tests, mostly adding better error checking. The test errors mentioned above were due to race conditions, were fixed. Smoke tests (i.e. TestServerStopEvent) are now more reliable.

Keeping this open as a general issue for improving existing unit tests. PRs welcome.

flashmob avatar Jan 30 '19 13:01 flashmob