django-socialregistration icon indicating copy to clipboard operation
django-socialregistration copied to clipboard

facebook_js contrib

Open rosscdh opened this issue 12 years ago • 6 comments

Hey there,

Firstly thanks for your work on this great app.

I found that I needed the facebook-js-sdk for one of my products and am working on a version that removes the dependency on the facebook python sdk (being depreciated by facebook from what I understand) and replaces it (at least the basic login/signup functionality atm) with the facebook js sdk.

Its still quite rough; but I'd like your feedback on its direction anyway :)

Best regards Ross

rosscdh avatar Jul 19 '12 06:07 rosscdh

Hi

Heh, funny. One of the reasons for the version jump and partial rewrite from v0.4 to v0.5 was getting rid of the JS SDK as there was not really a convenient way to test it (and it used to break in practice quite often or just display empty popups). Unfortunately - Facebook shortly afterwards killed the Python SDK. I've wanted to cut it out and replace it with requests for a while now but just have not had any time to do so.

I did find though that you can use the JS SDK with socialreg when doing the server side auth flow. You exchange the tokens on your site via AJAX once authenticated (or embed them in the site [caution - HTTPS!]) and then script away.

I do like that you went down the route of creating contrib.facebook_js though instead of cutting into contrib.facebook. There are a couple of quirky things in the code that I'll comment on when I get another second to look at it.

flashingpumpkin avatar Jul 20 '12 09:07 flashingpumpkin

Hey there Alen,

Thanks for the reply and the history! I had a feeling it would have been related to the facebook hop/skip/jump process; but in the end its all good!

I look forward to your comments, I'm more than happy to take them on board as of course its your product :) Just please bear in mind thats its def a work in progress with a view to merging down the track when it becomes more "production" ready :)

I was thinking about making the Javascript Callbacks configurable (via settings) so that the user could write their callbacks in their js and simply have SR whack them back on the system events.

And probably would also, be a good idea to write an abstraction for all of the FB subscribe events... but thats something i'll work on as we need it.

Best regards Ross Crawford-d'Heureuse

On Fri, Jul 20, 2012 at 11:59 AM, Alen Mujezinovic < [email protected]

wrote:

Hi

Heh, funny. One of the reasons for the version jump and partial rewrite from v0.4 to v0.5 was getting rid of the JS SDK as there was not really a convenient way to test it. Unfortunately - Facebook shortly afterwards killed declared the Python SDK deprecated and I've wanted to cut it out and replace it with requests for a while now but just have not had any time to do.

I did find though that you can use the JS SDK with socialreg when doing the server side auth flow. You just exchange the tokens on your site via AJAX once authenticated (or embed them in the site [caution - HTTPS!]) and then script away.

I do like that you went down the route of creating contrib.facebook_js though instead of cutting into contrib.facebook. There are a couple of quirky things in the code that I'll comment on when I get another second to look at it.


Reply to this email directly or view it on GitHub:

https://github.com/flashingpumpkin/django-socialregistration/pull/161#issuecomment-7126598

rosscdh avatar Jul 20 '12 13:07 rosscdh

This pull request passes (merged 2c630841 into e2b5de3b).

travisbot avatar Aug 11 '12 13:08 travisbot

This pull request passes (merged 4b597c09 into e2b5de3b).

travisbot avatar Aug 17 '12 15:08 travisbot

This pull request passes (merged c070851c into e2b5de3b).

travisbot avatar Aug 20 '12 05:08 travisbot

This pull request passes (merged 8de6640c into e2b5de3b).

travisbot avatar Aug 22 '12 05:08 travisbot