mev-geth icon indicating copy to clipboard operation
mev-geth copied to clipboard

[Feature request] Add reverts to eth_estimateBundleGas

Open bertmiller opened this issue 4 years ago • 1 comments

A request from a searcher:

Rationale

This is the current output when eth_callBundle is called on a reverting bundle

{'bundleGasPrice': '0',
 'bundleHash': '0x7abc07a2de269530f4f77cbde9c1979297d4577e673fe09b52fcb1c8bbfb8e54',
 'coinbaseDiff': '0',
 'ethSentToCoinbase': '0',
 'gasFees': '0',
 'results': [{'coinbaseDiff': '0',
   'error': 'execution reverted',
   'ethSentToCoinbase': '0',
   'fromAddress': '0xabcd',
   'gasFees': '0',
   'gasPrice': '0',
   'gasUsed': 24211,
   'toAddress': '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2',
   'txHash': '0x5bc1382d2c8165def27854e0a61c1e6dc4e85a1e1da2b81d2d429a10b593d227'}],
 'stateBlockNumber': 14017260,
 'totalGasUsed': 24211}

This is the results of calling eth_estimateBundleGas when calling on a reverting bundle: {'results': [{'gasUsed': 24223}]}

It would be good to return a similar "error" vs no error on estimateGasBundle

Implementation

Implementation should be relatively straight forward, it would be possible to reuse some of the work with eth_callBundle.

bertmiller avatar Jan 16 '22 15:01 bertmiller

revert estimated gas err #144 @bertmiller

ziadghali2 avatar Dec 14 '22 19:12 ziadghali2