mev-boost icon indicating copy to clipboard operation
mev-boost copied to clipboard

#253 added env var to log to file

Open 0xste opened this issue 3 years ago • 1 comments

📝 Summary

adds optional env-var to specify a log file location.

⛱ Motivation and Context

This enables us to ship logs off-node

📚 References

#253 - required for prometheus metrics grok exporter dependency


✅ I have run these commands

  • [ ✅ ] make lint
  • [ ✅ ] make test-race
  • [ ✅] go mod tidy

0xste avatar Oct 12 '22 13:10 0xste

probably needs to support log-file-rotation etc... draft for now

0xste avatar Oct 12 '22 13:10 0xste

Usually it's best practice to only log to stdout/stderr and have other tools (i.e. systemd, etc) take care of writing to files and rotating.

metachris avatar Oct 25 '22 10:10 metachris

anyhow, thanks for contributing 🙏 ⭐

metachris avatar Oct 30 '22 13:10 metachris