mev-boost icon indicating copy to clipboard operation
mev-boost copied to clipboard

check for new releases on github, and log a warn if update is possible

Open metachris opened this issue 2 years ago • 2 comments

📝 Summary

This is a proposal and request for comments and input.

  • check for new mev-boost releases on Github regularly, and log (info) if update is possible
  • can be disabled with setting env var DISABLE_NEW_RELEASE_CHECK=1
  • default check time: at startup and every 2 hours
  • timeout can be configured with NEW_RELEASE_CHECK_INTERVAL_H

Question: should this be opt-in or opt-out?

⛱ Motivation and Context

mev-boost users should get notified if new releases are available


✅ I have run these commands

  • [x] make lint
  • [x] make test-race
  • [x] go mod tidy

metachris avatar Sep 18 '22 16:09 metachris

Codecov Report

Merging #329 (75a0bce) into main (97207c6) will decrease coverage by 1.14%. The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   82.14%   81.00%   -1.15%     
==========================================
  Files           5        5              
  Lines         661      695      +34     
==========================================
+ Hits          543      563      +20     
- Misses         90       99       +9     
- Partials       28       33       +5     
Flag Coverage Δ
unittests 81.00% <58.82%> (-1.15%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/service.go 80.04% <58.33%> (-0.67%) :arrow_down:
server/utils.go 69.23% <59.09%> (-3.24%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 18 '22 16:09 codecov-commenter

I think opt-in is a good idea, it would notify validators to update mev-boost that may be hard to reach or not monitoring communication channels.

avalonche avatar Sep 19 '22 15:09 avalonche

I like the idea but I'm not sure how useful it would be in practice. The type of person that this caters to probably isn't the type of person that regularly checks their mev-boost logs, only when something isn't working properly.

jtraglia avatar Nov 04 '22 15:11 jtraglia

closing this for now. may be worth reconsidering with an opt-in flag

metachris avatar Nov 04 '22 20:11 metachris