mev-boost icon indicating copy to clipboard operation
mev-boost copied to clipboard

Prometheus metrics

Open jmcruz1983 opened this issue 3 years ago • 6 comments

A good improvement would be mev-boost producing prometheus metrics with /metrics endpoint

jmcruz1983 avatar Aug 18 '22 14:08 jmcruz1983

open to a PR for this. what metrics are you thinking of?

metachris avatar Aug 23 '22 07:08 metachris

I was thinking about metrics around validators registered and blocks produced, wdyt?

jmcruz1983 avatar Aug 23 '22 08:08 jmcruz1983

Dropped a draft PR, largely the metrics collected thus far are for more operational/performance metrics, would be good to add validator and block-level metrics additionally, would be great to hear thoughts on this.

0xste avatar Sep 05 '22 18:09 0xste

Yes, I agree, validator and block level metrics would be quite handy Thanks!

jmcruz1983 avatar Sep 05 '22 19:09 jmcruz1983

Going for a sidecar approach for this, as opposed to the "deep" integration originally proposed in #294 given comments from @metachris

These changes are deep and extensive into the core system and logic. Considering that mev-boost is run at 50% of all validators, it is too risky and impactful for adding a large amount of new logic in the core flows at the current time.

Perhaps consider collecting the metrics from the logs, or thinking about a possible plugin interface. 🤔


Latest is on: #370 The idea is that you'd run a grok-exporter with an mev-boost flavoured configuration Some care points:

  • Changes to log format would affect the metrics exported
    • Mitigation: Config owned/managed/maintained in the mev-boost repo (would ensure alignment?)
  • The fstab/grok_exporter project is not currently maintained afaics
    • Mitigation: it's a pretty simple (but powerful) go tool, i'm happy to contribute if any critical bugs come about, this monitoring is non-invasive, so you can always fall back to logs (or some other grok implementation if required)
  • There is currently no maintained docker container for grok-exporter
    • Mitigation: Initial repo here and published to docker-hub here

0xste avatar Oct 07 '22 15:10 0xste