ethers-provider-flashbots-bundle icon indicating copy to clipboard operation
ethers-provider-flashbots-bundle copied to clipboard

Typo in readme

Open relyt29 opened this issue 3 years ago • 1 comments

in the "Simulate and Send" section, the code should read:

const signedTransactionBundle = await flashbotsProvider.signBundle(transactionBundle)
const simulation = await flashbotsProvider.simulate(signedTransactionBundle, targetBlockNumber)

instead of

const signedTransactionBundle = await flashbotsProvider.signBundle(transactionBundle)
const simulation = await flashbotsProvider.simulate(signedTransactions, targetBlockNumber)

I was confused for a second and looking back trying to figure out if I had a variable missing until I noticed whoever wrote the readme was copying and pasting from demo.ts

relyt29 avatar Sep 01 '21 08:09 relyt29

This issue can be closed.

Fix: https://github.com/flashbots/ethers-provider-flashbots-bundle/commit/500b4498e51fc77600aca61cdc6c429215741d97

nullbitx8 avatar Oct 13 '21 02:10 nullbitx8