builder icon indicating copy to clipboard operation
builder copied to clipboard

Question about Blacklist Functionality.

Open MPLA101 opened this issue 1 year ago • 1 comments

As per the README.md, below flag is used to ignore transactions that include mentioned addresses.

--builder.blacklist value : Path to file containing blacklisted addresses, json-encoded list of strings. Builder will ignore transactions that touch mentioned addresses.`

When I checked the code, I see that the Blacklist is only referenced in following functions. eth/block-validation/api.go:: verifyTransactions eth/block-validation/api.go:: isBlacklisted eth/block-validation/api.go:: verifyTraces

All these functions are called from ValidateBuilderSubmissionV2 which in turn is called only when dryRun flag is set. if b.dryRun { err = b.validator.ValidateBuilderSubmissionV2 ....

As per my current understanding, the builder exclusively checks for Blacklisted addresses during dryRun mode. If this understanding is accurate, I kindly request that this be explicitly documented for the sake of clarity. Such documentation is essential for users who rely on this feature for regulatory compliance and operational purposes.

MPLA101 avatar Nov 08 '23 15:11 MPLA101

Builder uses blacklist for validation and building.

so if you set "--builder.blacklist value" it will be used by the builder (miner module) and it will exclude that txs.

dvush avatar Feb 22 '24 12:02 dvush