boost-geth-builder icon indicating copy to clipboard operation
boost-geth-builder copied to clipboard

Very often the reward payment TX fails - "proposer payment not successful!"

Open krasi-georgiev opened this issue 3 years ago • 5 comments

Very often the payment TX returns status 0.

I am trying to troubleshoot, but so far, can't find the culprit.

proposer payment not successful!

Added some additional logs to see if the TX params are correct and all seems fine

INFO [10-13|16:14:12.249] Before creating validator profit         validatorCoinbase=0x388C818CA8B9251b393131C08a736A67ccB19297 builderCoinbase=............. builderCoinbaseBalanceBefore=477349964620000 builderCoinbaseBalanceAfter=56217170097643854   profit=55739820133023854

ERROR[10-13|16:14:12.295] proposer payment not successful!         block=15740317 price=37973497401 gasUsed=21000 value=54752509200597854   nonce=3 receiptStatus=0

krasi-georgiev avatar Oct 13 '22 16:10 krasi-georgiev

Hey, thanks for the report. This issue will happen sometimes due to the proposer's fee recipient transfer requiring more than the allocated gas. Feel free to propose a solution, we will work on it in the coming week or so.

Ruteri avatar Oct 13 '22 18:10 Ruteri

at the moment it is set to 26k, In what cases it requires more than that?

krasi-georgiev avatar Oct 13 '22 20:10 krasi-georgiev

Hmm, you might be right if the recipient is a contract and the receive function does some fancy things it might go over this limit. I will add some more logging and if this is confirmed I guess the only way would be to either try to simulate with a higher gas cap or hard code a general higher gas limit.

krasi-georgiev avatar Oct 15 '22 09:10 krasi-georgiev

@Ruteri why not simulate the Transfer TX to get the real gas usage?

krasi-georgiev avatar Oct 17 '22 11:10 krasi-georgiev

That's the general idea, but it's not simple. Simulation at the top of the block is not correct since there may be no funds to transfer yet. The gas used can differ from simulation based on a specific amount transferred. Simulating at the bottom won't work as you need to pre-reserve the gas. We are working on a proper fix but it will take us some more time.

Ruteri avatar Oct 18 '22 08:10 Ruteri