framework icon indicating copy to clipboard operation
framework copied to clipboard

Search box improvements on tablet devices

Open YUCLing opened this issue 4 months ago • 0 comments

Fixes #0000

Changes proposed in this pull request:

  • Move onclick event to the whole search area, making the modal open when clicking on the search icon on table devices.
  • Blurs input when onclick, removes the unnecessary animation on tablet devices.

Reviewers should focus on:

Screenshot

QA

Necessity

  • [ ] Has the problem that is being solved here been clearly explained?
  • [ ] If applicable, have various options for solving this problem been considered?
  • [ ] For core PRs, does this need to be in core, or could it be in an extension?
  • [ ] Are we willing to maintain this for years / potentially forever?

Confirmed

  • [x] Frontend changes: tested on a local Flarum installation.
  • [ ] Backend changes: tests are green (run composer test).
  • [ ] Core developer confirmed locally this works as intended.
  • [ ] Tests have been added, or are not appropriate here.

Required changes:

  • [ ] Related documentation PR: (Remove if irrelevant)
  • [ ] Related core extension PRs: (Remove if irrelevant)

YUCLing avatar Oct 17 '24 17:10 YUCLing