framework icon indicating copy to clipboard operation
framework copied to clipboard

Tag displays as deleted once it's removed from a conversation

Open orschiro opened this issue 3 years ago • 2 comments

Current Behavior

One of our tags shows as deleted once it's removed from a conversation.

Steps to Reproduce

  1. Go to https://community.sheetgo.com/d/209-barcode-scanner/6
  2. Remove the tag "fixed" from the conversation

Expected Behavior

It should read "...removed the fixed tag".

Instead it's reading "...removed the Deleted tag".

Screenshots

Video: https://drive.google.com/file/d/1QrZzd42RdtJlfjH_RllfppRKUfO-wcvP/view?usp=drivesdk

Environment

Flarum 1.4.0 hosted at Free Flarum.

Output of php flarum info

No response

Possible Solution

No response

Additional Context

Thanks for your help!

orschiro avatar Aug 26 '22 16:08 orschiro

This is caused by the fact that tags are now no longer globally loaded and available in the JS store from the get-go. I don't know how to easily solve this, because we don't keep track of tags removed from the discussion. We'd probably need to change how event posts for Tags are stored so that tags that are mutated are a relation and can be included in the json payload.

🤔

luceos avatar Aug 31 '22 12:08 luceos

Tag mentions feature would actually solve this. The event post would have the tags attached as mentions which can then easily be loaded. Sasha first mentioned the idea on discuss https://discuss.flarum.org/d/31426-mentioning-tags-within-posts/10

SychO9 avatar Aug 31 '22 13:08 SychO9