framework
framework copied to clipboard
Readme file for Statistics extension?
Current Behavior
Hi all,
Could https://github.com/flarum/statistics add a readme file that explains the basics of this extension?
For example what the green and grey line mean and what the difference between the two is.
That's not really clear from just looking at it (at least for me).
Thanks!
Steps to Reproduce
- Install the extension
- No readme file present
Expected Behavior
There should be a readme file that explains the basics.
Screenshots
Environment
- Flarum version: 1.4.0
Output of php flarum info
No response
Possible Solution
No response
Additional Context
No response
This isn't a bug though 😅
I honestly don't know what the gray line means either. The extension needs a refactor/rewrite imo.
Grey line is the last period -- same data as is used for the % comparisons
Thanks David.
So for example, if I select last 7 days, then green is last 7 days and grey the 7 days before that?
On Tue, 16 Aug 2022, 18:48 David Wheatley, @.***> wrote:
Grey line is the last period -- same data as is used for the % comparisons
— Reply to this email directly, view it on GitHub https://github.com/flarum/framework/issues/3604#issuecomment-1216893295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJXQ4RP6NXMQ64HXRJI73VZPA4JANCNFSM56V4VSOA . You are receiving this because you authored the thread.Message ID: @.***>
Yep, spot on!
Thanks! Maybe a legend somewhere next to the graph would help explain that?
On Tue, 16 Aug 2022, 21:39 David Wheatley, @.***> wrote:
Yep, spot on!
— Reply to this email directly, view it on GitHub https://github.com/flarum/framework/issues/3604#issuecomment-1217082710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJXQ3QVGK3262NHWCXJ5LVZPU6BANCNFSM56V4VSOA . You are receiving this because you authored the thread.Message ID: @.***>
@orschiro are the changes in the linked PR better? (screenshots)
@SychO9 yes, much better, thank you so much!