framework icon indicating copy to clipboard operation
framework copied to clipboard

feat: Add custom class for email confirmation alert

Open rob006 opened this issue 3 years ago • 2 comments

Changes proposed in this pull request:

Currently this alert uses generic classes and it is quite hard to distinguish this particular alert from any other alerts. Custom class should simplify for example adding custom styles for this alert.

Necessity

  • [x] Has the problem that is being solved here been clearly explained?
  • [x] If applicable, have various options for solving this problem been considered?
  • [x] For core PRs, does this need to be in core, or could it be in an extension?
  • [x] Are we willing to maintain this for years / potentially forever?

Confirmed

  • [ ] Frontend changes: tested on a local Flarum installation.
  • [ ] Backend changes: tests are green (run composer test).
  • [ ] Core developer confirmed locally this works as intended.
  • [ ] Tests have been added, or are not appropriate here.

Required changes:

  • [ ] Related documentation PR: (Remove if irrelevant)
  • [ ] Related core extension PRs: (Remove if irrelevant)

rob006 avatar Aug 05 '22 16:08 rob006

From styling perspective it is better to add this class on the most outermost wrapper. If we want to add this on ContainedAlert, then IMO we should get rid of this div wrapper.

rob006 avatar Aug 05 '22 19:08 rob006

Maybe we could add a class to both? If we restructure how this alert is added, then I don't want to accidentally drop this class and break some styling.

davwheat avatar Aug 06 '22 09:08 davwheat