flareact icon indicating copy to clipboard operation
flareact copied to clipboard

WIP: Feature/redirects

Open subhendukundu opened this issue 4 years ago • 4 comments

This contains a part of #124 This is my bad. If 124 is getting merged then I don't have to remove them but it doesn't, I will resolve it.

Can someone please review this and tell me what do you think?

subhendukundu avatar Feb 15 '21 11:02 subhendukundu

I need some suggestions on this one. Can anyone help?

subhendukundu avatar Feb 17 '21 14:02 subhendukundu

I need some suggestions on this one. Can anyone help?

Probably better to just ask ;)

traffisco avatar Feb 17 '21 15:02 traffisco

So the way I am trying to do here is

  1. Read the config file
  2. Get the redirect data, create a json file in the worker file (As config file does module.exports where we are reading as import and this gonna throw error due to es and commonjs. Question on this one, can we make webpack to read it as well? if not any other alternative?
  3. This is working so far. Now I will try to add regex and patterns. But does the approach look good?

subhendukundu avatar Feb 17 '21 15:02 subhendukundu

@jplhomer how about this one? Am I heading in the right direction?

subhendukundu avatar Feb 19 '21 03:02 subhendukundu

:tada: This PR is included in version 1.5.0-canary.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 21 '22 11:12 github-actions[bot]