Jim Graham

Results 25 issues of Jim Graham

Test engine roll, do not merge.

engine
will affect goldens

The preroll method should produce bounds relative to the transform it was given. Before calling the paint method, the bounds supplied by preroll will be compared to the clip bounds...

team
engine
passed first triage

We are seeing these kinds of failures a lot lately and it looks like the issue is that the Dart mechanism used to load all of the tests has a...

team: flakes

We occasionally see flaky failures downloading gradle to run the benchmarks in the framework post-submit tasks. Generally the tasks will be downloading the same versions so a local cache would...

team-infra
P0
fyi-android
triaged-infra

During some new development work that might make transform resets more expensive we realized that the resets were mostly coming from the calls to snap the transform to a pixel...

Previously the DisplayListBuilder would only pass along bounds for a saveLayer when they were supplied by the caller that was building the DisplayList. This would require Impeller to use post-processing...

e: impeller

Simplifies some of the repetitive computations in the cap and join operations in the Impeller stroking code. Precomputes the data and consolidates it into a structure for simplified passing to...

e: impeller

In https://github.com/flutter/engine/pull/53083 the test for a "simple" round rect was relaxed in one case by using fuzzy comparisons of the radii values, but made more restrictive in another case by...

engine
e: impeller

Skia paths, used by native code to implement Flutter paths, supports inverted fill types where the interior of the path is inverted (out to infinity in all directions). Flutter's Dart...

Fixes https://github.com/flutter/flutter/issues/151034 Fast round rects were recently restricted to circular corners, but elliptical round rects can also go through the fast path.

e: impeller