shell-operator icon indicating copy to clipboard operation
shell-operator copied to clipboard

Enable EnableKubeEventCb in dynamicaly created resource informer

Open and-1 opened this issue 3 years ago • 1 comments

Overview

Dynamic resource informer created with disabled eventCbEnabled flag, so created resources in new namespace does not handled.

What this PR does / why we need it

Fix #379 issue

and-1 avatar May 24 '22 13:05 and-1

Oh, #379! Thanks for the PR. It seems you've got the root cause: creating new namespaces after Synchronization leads to informers with disabled callbacks. But adding new informer with enabled callback is not correct. Callback should be enabled if EnableKubeEventCb was called on monitor (this happens after Synchronization). So some kind of additonal flag is required.

diafour avatar May 24 '22 13:05 diafour

Fixed in #411, available since v1.0.11

diafour avatar Aug 25 '22 07:08 diafour