addon-operator icon indicating copy to clipboard operation
addon-operator copied to clipboard

fix camelCase to kebab-case conversion

Open miklezzzz opened this issue 1 year ago • 2 comments

Overview

The camelCase to kebab-case string conversion function is updated to use "github.com/ettle/strcase" package instead of local implementation. It should allow converting module names containing digits more correctly.

What this PR does / why we need it

It updates the way we convert camelCased strings to kebab-cased. At now, if we have something like 'l2-load-balancer' in kebab-case, after converting to camelCase and back it ends up with 'l-2-load-balancer'.

Special notes for your reviewer

miklezzzz avatar Mar 21 '24 08:03 miklezzzz

here is a diff output between values before and after the changes image

miklezzzz avatar Mar 21 '24 11:03 miklezzzz

I think I can't comprehend all possible consequences of these changes, need you to spend a couple of minutes thinking through a possible worst case scenario :) @nabokihms @yalosev

miklezzzz avatar Mar 21 '24 11:03 miklezzzz