flang icon indicating copy to clipboard operation
flang copied to clipboard

Fix dllimport code generation for module symbols

Open kaadam opened this issue 3 years ago • 4 comments

kaadam avatar Nov 23 '21 16:11 kaadam

Please add a test case?

bryanpkc avatar Apr 05 '22 16:04 bryanpkc

If Flang always generates dllimport attribute for global symbols, do we still need the PGDLL macro and !DEC$ ATTRIBUTES DLLEXPORT in the runtime?

bryanpkc avatar Apr 05 '22 16:04 bryanpkc

Please add a test case?

@bryanpkc This test would be Windows specific. Currently we're not able to run Flang tests on Windows, what about the policy in this case?

kaadam avatar Apr 21 '22 11:04 kaadam

@kaadam Sorry I didn't see your question! I think GitHub actually provides Windows runners:

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Do you think we could leverage them to set up some CI jobs on Windows?

bryanpkc avatar Jul 27 '22 12:07 bryanpkc

This needs a rebase.

kiranchandramohan avatar Dec 14 '22 15:12 kiranchandramohan