f18 icon indicating copy to clipboard operation
f18 copied to clipboard

[OpenMP] Semantic checks for taskloop

Open kiranchandramohan opened this issue 5 years ago • 7 comments

Section 2.9.2 of the OpenMP standard describes the Taskloop construct. I am planning to implement the checks.

Note: This issue is being raised to avoid duplication of work. Please update the projects page.

kiranchandramohan avatar Jul 15 '19 10:07 kiranchandramohan

Hi Kiran, what are you planning to do? For example, right now, there are no symbols or scopes for OpenMP as far as I know. Are you going to sync with Brian & work on legality of clauses in taskloop?

sscalpone avatar Jul 16 '19 19:07 sscalpone

Yes, I am going to work on the legality of taskloop clauses. Most of the checks seem straightforward and are similar to existing checks, either permitted clauses or clauses that can only be used once. Then a few about two clauses not occurring together, being a positive integer etc.

I was thinking that these strucutral checks for OpenMP constructs were put in the Projects page so that others can help with the implementation of these checks. I will sync with Brian. @ichoyjx please let me know in case there is something missing before task loop checks can be taken up or if all these checks are something you were planning to do yourself.

kiranchandramohan avatar Jul 16 '19 21:07 kiranchandramohan

Hi Kiran, if you are targeting on the checks for the following you mentioned:

either permitted clauses or clauses that can only be used once. Then a few about two clauses not occurring together, being a positive integer, etc.

Then nothing is missing that may block the implementation. Just FYI, the Projects page listed almost all the TODO directives.

ichoyjx avatar Jul 16 '19 22:07 ichoyjx

https://github.com/DavidTruby is working on this.

kiranchandramohan avatar Aug 22 '19 09:08 kiranchandramohan

Taskloop checks are now implemented except for branching in and out of a loop, which needs also doing for standard loops.

DavidTruby avatar Sep 10 '19 13:09 DavidTruby

@kiranchandramohan You can close this issue if you are satisfied.

sscalpone avatar Sep 10 '19 16:09 sscalpone

@sscalpone we are waiting for @ichoyjx to implement the branching in and out of a loop. If he will implement for taskloops also then we can close the ticket. Otherwise, this ticket has to remain open as a reminder to use Brian's branch checks for taskloop also.

kiranchandramohan avatar Sep 11 '19 09:09 kiranchandramohan