f18 icon indicating copy to clipboard operation
f18 copied to clipboard

Convert Preprocessing tests to lit

Open LukeIreland1 opened this issue 4 years ago • 2 comments

Preprocessing tests need to be converted to run with lit, like the other Fortran tests.

LukeIreland1 avatar Mar 06 '20 16:03 LukeIreland1

@RichBarton-Arm is this complete?

DavidTruby avatar Apr 24 '20 14:04 DavidTruby

No, the tests in the test/Preprocessing directory are not ported to lit yet. These tests were never being run on F18 and we tell lit to ignore them right now.

The tests are execution tests, i.e. they build Fortran snippets that run and print Pass/Fail messages. Each test relies on some functionality from the preprocessor being correctly honoured in order for the Pass message to print.

It should not be necessary to compile and run the test in order to check the preprocessor. I would expect tests on the output of -E should be sufficient and more desirable because they isolate the preprocessor so would not fail due to any subsequent issue unrelated to the preprocessor. I think this should be done at the same time as making these lit tests so in reality this might be more than a port, more a re-write/consolidate and porting job.

RichBarton-Arm avatar Apr 24 '20 16:04 RichBarton-Arm