f18-llvm-project
f18-llvm-project copied to clipboard
flang-compiler
Added OpenMP 5.0 specification based lowering of atomic read and write
@NimishMishra Will you be able to address the changes requested by Eric and Peixin?
@kiranchandramohan I got caught up elsewhere. I'll pick this PR on priority. I see Eric is fine with ReferenceType. I don't have any idea on HeapType, PointerType, and LLVMPointerType. Can you give some idea on which one to pick up?
Except for those code style issues, the function code looks good to me.
BTW, it seems that some semantic checks are missing for atomic construct. For example, at most one hint clause can be in atomic construct, and which memory order clauses can be in which atomic construct. Not sure if they are beyond OpenMP 1.1.
Except for those code style issues, the function code looks good to me.
BTW, it seems that some semantic checks are missing for atomic construct. For example, at most one hint clause can be in atomic construct, and which memory order clauses can be in which atomic construct. Not sure if they are beyond OpenMP 1.1.
I'll do the code style changes. As far as the semantic checks are concerned, I have verified that they are present in llvm main repository. I did not implement them; they were already there.
I'll take this PR on priority.
Could you create a copy of this for upstream llvm-project as well?
Yes. I will create a upstream differential for this PR.
@shraiysh have you reviewed this PR? If you are OK, please approve.
Note: This PR can no longer be merged since #1570 is merged. Once we reach a consensus on https://reviews.llvm.org/D122725, I will modify this PR too to that end.