antares icon indicating copy to clipboard operation
antares copied to clipboard

Published 20 hours ago • verified publisher icon flandreas

Joining wires can lead to corrupt pin connections

Open flandreas opened this issue 1 year ago • 6 comments

This can be caused by joining open-ended wires or deleting wire junctions. Leads to pins not properly connected to the net of the wire, which results in simulation not working as expected.

Detected in #713.

flandreas avatar Apr 23 '24 17:04 flandreas

Thanks for taking care of this! I tested it on the head of master and now this one reproduces a malfunction:

https://github.com/flandreas/antares/assets/5798899/2a94cfaa-e727-4d32-9f64-0b7f0752bacc

fpw avatar Apr 24 '24 15:04 fpw

Thanks! Reopened

flandreas avatar Apr 25 '24 08:04 flandreas

Cannot be reproduced generally with a simple circuit having the same structure like the problematic region like in the video.

However, it CAN be reproduced using the dump provided in #713 with exactly the wire segment you've deleted. I'll investigate..

flandreas avatar Apr 25 '24 10:04 flandreas

Reproducible when deleting the selected wire in this simplified circuit:

Screenshot 2024-04-25 at 16 44 22

The problem occurs when the wire that gets joined is connected with yet another junction node.

flandreas avatar Apr 25 '24 14:04 flandreas

Great find, I think all instances in which I've encountered this bug previously were related to long wire junction ladders like this.

fpw avatar Apr 25 '24 14:04 fpw

Unfortunately I think I've introduced this one with my last fix. The scenario above isn't reproducible in the productive version 1.11.1.

flandreas avatar Apr 25 '24 15:04 flandreas