dragonflagon-fvtt icon indicating copy to clipboard operation
dragonflagon-fvtt copied to clipboard

DF Module Buttons no longer hides buttons when switching layers (found with DF Curvy Walls)

Open kagedansa opened this issue 2 years ago • 4 comments

Module DF Module Buttons 1.4.2

Describe the issue There are errors in the console log associated with "DF Curvy Walls 3.4.0". The visible effect in Foundry (V10.291) is that module buttons are no longer hidden when switching to other layers.

To Reproduce Steps to reproduce the behavior:

  1. Switch to wall layer
  2. Switch to other layer
  3. See error

Screenshots (Optional) grafik grafik grafik grafik

kagedansa avatar Dec 06 '22 13:12 kagedansa

Commenting to get updates.

Cryotechnik avatar Jan 29 '23 03:01 Cryotechnik

Noticing the exact same error, Even with no other modules installed.

NelanaPrime avatar Feb 08 '23 03:02 NelanaPrime

I suspect this is caused by the enhancement added in 1.4.1; I rolled back to 1.4.0 manually and the buttons hide as expected.

tjlanza avatar Mar 02 '23 15:03 tjlanza

Yeah, commit c8d6169dba29e2bdb54e8f7486fef6a5bc57bf1b is to blame. When I do a git revert on it in the current main, build and copy it, the buttons vanish again like they should.

DrMcCoy avatar Mar 03 '23 07:03 DrMcCoy